Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#88 closed Defect (Fixed)

Inactive Data Records Previewing, Publishing

Reported by: Lois Haggard Owned by: Garth Braithwaite
Priority: *High Milestone:
Component: Admin-App Version: 2.0
Severity: Keywords:
Cc:

Description (last modified by Lois Haggard)

I am seeing inactive data records previewing and publishing. The data records are not checked "active" on the Graph Values Admin page. They have been saved to the INDICATOR_VIEW_VALUES DB table with no active flag (see attached InactiveDataRecordsDB.PNG). When I preview or publish, the inactive records are being published to the indicator.xml and used in the graph (see attached InactiveDataRecordsPreview.PNG).

I belive these rules should apply:

  • Only Active Data records should be published to the DB.
  • In addition, because some previously used/published DB records may later be made inactive, only Active DB records should be published to the Indicator.xml file.

RELATED TO TICKET #84.

Ticket #84 reports that inactive records in the DATASET_CATEGORY_VALUE table are being displayed on the Admin app's Graph Values page.

MORE INFORMATION
I think this is the same issue. Just to be safe, I'll document it here.

We saw a datapoint for a funky, future year in an indicator report graph that seems to indicate an INDICATOR_VIEW_VALUE of about 8.0 (!DiabPrev1.PNG).

We checked the indicator report "View Graph Values" page to see what was there, and there was a data row in the table, but it did not seem contain any value (!DiabPrev2.PNG).

We checked in the DiabPrevl.Year.NM_US.xml file to see if we could see anything (!DiabPrev3.PNG), and there WAS an inactive <INDICATOR_VIEW_VALUE> record for 2013.

We checked in the Admin app to see if we could see anything (!DiabPrev4.PNG), year 2013 didn't seem to have anything in it.

We checked the Admin DB INDICATOR_VIEW_VALUE table (!DiabPrev5.PNG), and there was an inactive record for series 1, year 2013.

So I'm GUESSING that someone had once upon a time saved the Graph Values page with a value in 2013, and gone back and fixed it later. But the damage had already been done, and a record for 2013 had already been saved to the DB table.

Re: where IBIS got the value of ~8 to plug into the graph, I can't say.


11/5/2010. Lois verified this defect is fixed. Inactive data records are not being used in graphs or graph values previews and are not being published indicator_view.xml.

Those issues were fixed in the ibisph-2-rc3.jar file submitted by Garth on 11/2/2010.

Attachments (7)

InactiveDataRecordsDB.PNG (83.1 KB) - added by Lois Haggard 10 years ago.
InactiveDataRecordsPreview.PNG (251.4 KB) - added by Lois Haggard 10 years ago.
DiabPrev1.PNG (63.5 KB) - added by Lois Haggard 10 years ago.
DiabPrev2.PNG (31.9 KB) - added by Lois Haggard 10 years ago.
DiabPrev3.PNG (41.1 KB) - added by Lois Haggard 10 years ago.
DiabPrev4.PNG (38.2 KB) - added by Lois Haggard 10 years ago.
DiabPrev5.PNG (34.8 KB) - added by Lois Haggard 10 years ago.

Download all attachments as: .zip

Change History (21)

Changed 10 years ago by Lois Haggard

Attachment: InactiveDataRecordsDB.PNG added

Changed 10 years ago by Lois Haggard

comment:1 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:2 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:3 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:4 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:5 Changed 10 years ago by Lois Haggard

Description: modified (diff)

Changed 10 years ago by Lois Haggard

Attachment: DiabPrev1.PNG added

Changed 10 years ago by Lois Haggard

Attachment: DiabPrev2.PNG added

Changed 10 years ago by Lois Haggard

Attachment: DiabPrev3.PNG added

Changed 10 years ago by Lois Haggard

Attachment: DiabPrev4.PNG added

Changed 10 years ago by Lois Haggard

Attachment: DiabPrev5.PNG added

comment:6 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:7 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:8 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:9 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:10 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:11 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:12 Changed 10 years ago by Lois Haggard

Description: modified (diff)
Resolution: fixed
Status: newclosed

comment:13 Changed 10 years ago by Lois Haggard

Description: modified (diff)

comment:14 Changed 9 years ago by (none)

Milestone: IBIS-PH Admin-2

Milestone IBIS-PH Admin-2 deleted

Note: See TracTickets for help on using tickets.