Opened 10 years ago

Closed 8 years ago

#82 closed Defect (Fixed)

Admin publishing "phantom" related indicator records

Reported by: Lois Haggard Owned by: Kim Neerings
Priority: +Medium Milestone: 2.1 - Testing
Component: Admin-App Version: 2.0
Severity: Unknown Keywords:
Cc:

Description (last modified by Lois Haggard)

There is nothing in my INDICATOR_RELATION table for this indicator, but when the xml was published to the View application, it had xml elements for 3 different indicator relations.

<RELATIONS>
	<RELATION name="SystemFactors">
	  <NAME>SystemFactors</NAME> 
	  <TITLE>Health Care System Factors</TITLE> 
	  <TEXT /> 
	</RELATION>
	<RELATION name="RiskFactors">
	  <NAME>RiskFactors</NAME> 
	  <TITLE>Risk Factors</TITLE> 
	  <TEXT /> 
	</RELATION>
	<RELATION name="HealthStatus">
	  <NAME>HealthStatus</NAME> 
	  <TITLE>Health Status Outcomes</TITLE> 
	  <TEXT /> 
	</RELATION>
  </RELATIONS>

This is a problem because it causes empty pages to display in the indicator profile report.


11/12/2010 – Lois tested. Still having an issue with publishing/display of related indicators. Could be I just don't understand how this is supposed to work - but there is either a problem with what is publishing or what is getting displayed in View.

Test indicator: Breast Cancer Deaths

  1. For all four RELATIONS:
    1. Admin app: Related Indicators page is showing no text and no selected related indicators.
    2. Admin DB: INDICATOR_TO_IND_RELATION table contains no records in which the INDICATOR_NAME field = CancerDeathBre
  2. I published CancerDeathBre.xml using the URL. The date was updated on the alphabetical index page, and there was no content on any of the related indicators pages.
  3. BUT –
    1. The related indicators left nav button appeared on the Breast Cancer indicator report page.
    2. The four left nav “relations” drop-down buttons appeared, although without any content in the four related indicators pages.
    3. Four <RELATION> elements have been published to the CancerDeathBre.xml file.
      <RELATIONS>
      	<RELATION name="PopChar">
      		<NAME>PopChar</NAME>
      		<TITLE>Relevant Population Characteristics</TITLE>
      		<TEXT/>
      	</RELATION>
      	<RELATION name="SystemFactors">
      		<NAME>SystemFactors</NAME>
      		<TITLE>Health Care System Factors</TITLE>
      		<TEXT/>
      	</RELATION>
      	<RELATION name="RiskFactors">
      		<NAME>RiskFactors</NAME>
      		<TITLE>Risk Factors</TITLE>
      		<TEXT/>
      	</RELATION>
      	<RELATION name="HealthStatus">
      		<NAME>HealthStatus</NAME>
      		<TITLE>Health Status Outcomes</TITLE>
      		<TEXT/>
      	</RELATION>
      </RELATIONS>
      

So… IBIS should EITHER not publish (Admin) these empty elements to the indicator.xml file, OR not display the Related Indicators left nav buttons on the indicator profile report page if BOTH the <TEXT> and <RELATED_INDICATOR> elements are empty.

Attachments (1)

PhantomRelationElements.PNG (20.3 KB) - added by Lois Haggard 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 10 years ago by Garth Braithwaite

Resolution: fixed
Status: newclosed

Fixed in the high 2200's.

comment:2 Changed 10 years ago by Lois Haggard

Description: modified (diff)
Resolution: fixed
Status: closedreopened

comment:3 Changed 10 years ago by Lois Haggard

Milestone: IBIS-PH View2 TestingIBIS-PH Admin-2 Testing

comment:4 Changed 10 years ago by Garth Braithwaite

Can't replicate. Tested http://localhost/ibisph-view/view?xslt=html/indicator/profile/CompleteProfilePage.xslt&xmlURL=http://localhost/ibisph-admin/indicator/DiabMgt.xml which produced correct CP page. This has a mix of all 4 relation text and IPs. Next tested a test IP that had no text or related IPs. XML was: a correct null element <RELATIONS/> and the CP page didn't display any relations nor were there any popouts on the menu. There was a blank menu item but this was because a view had not been defined - which should never be the case in the real world.

Guess as to what is going on: Using old published XML files that were produced prior to the relateds fix -or- the relateds are NOT in the published_profiles.xml file as is required. Could still be an issue but I need more info to debug like using base app (no NM modes), tested again current xml (which if publishing doesn't work can be grabbed and manually placed in the xml/indicator/profile/ dir via the url found in the "xmlURL" url parameter shown at the first of this reply). The last thing that would be handy is what core app pages this does not work on (e.g. CP or a view).

Changed 10 years ago by Lois Haggard

Attachment: PhantomRelationElements.PNG added

comment:5 Changed 10 years ago by Lois Haggard

Let's ignore the View app for the time being, except to look inside the published xml\indicator\profile\Demo10.xml file.

I used the Admin app to remove all related indicator text and selected indicators for my Demo10 indicator. And I deleted this:

<RELATIONS>
<RELATION name="PopChar"><NAME>PopChar</NAME><TITLE>Relevant Population Characteristics</TITLE><TEXT/></RELATION>
<RELATION name="SystemFactors"><NAME>SystemFactors</NAME><TITLE>Health Care System Factors</TITLE><TEXT/></RELATION>
<RELATION name="RiskFactors"><NAME>RiskFactors</NAME><TITLE>Risk Factors</TITLE><TEXT/></RELATION>
<RELATION name="HealthStatus"><NAME>HealthStatus</NAME><TITLE>Health Status Outcomes</TITLE><TEXT/></RELATION>
</RELATIONS>

And replaced it with this: <RELATIONS/>

After successfully publishing the indicator, using the "URL method," my xml\indicator\profile\Demo10.xml file had a fresh saved date/time. I open it up, and those <RELATION> records were published.

I checked the DB, and, ah! there are DB records in the INDICATOR_RELATION DB table for those four RELATIONs for the DEMO10 indicator (see attached PhantomRelationElements.PNG). The TEXT field is blank, but the DB records remained. In the INDICATOR_TO_IND_RELATION DB table, the records for the Demo10 indicator had been deleted.

I republish my Demo10 indicator, and this time, it publishes with only the !<RELATIONS/> element, as it should.

So what is the easiest solution?

  1. Upon saving to the INDICATOR_RELATION DB table, if the TEXT field is blank, delete the record.
  2. Either that or check both the INDICATOR_RELATION and INDICATOR_TO_IND_RELATION DB tables and only publish the appropriate <RELATION> element if any of those are non-blank.

Option 1 sounds easiest (not that I would really know! :0 )

comment:6 Changed 10 years ago by Lois Haggard

11/24/2010 - Conversation with Garth. "If there are no relateds in the INDICATOR_TO_IND_RELATION table and no text in this table, go ahead and delete the record in the INDICATOR_RELATION DB table."

comment:7 Changed 9 years ago by Garth Braithwaite

Owner: changed from Garth to Testing
Status: reopenednew

comment:8 Changed 9 years ago by (none)

Milestone: IBIS-PH Admin-2

Milestone IBIS-PH Admin-2 deleted

comment:9 Changed 8 years ago by Garth Braithwaite

Milestone: 2.1 - Testing
Severity: Unknown

comment:10 Changed 8 years ago by Kim Neerings

Owner: changed from Testing to Garth Braithwaite

comment:11 Changed 8 years ago by Garth Braithwaite

Owner: changed from Garth Braithwaite to Testing

Code updated SVN: 3990.

TESTING: Had to change behavior of the core db code. As such need to test ALL Admin pages saving and loading data. This includes creating new records etc. Look for anything that doesn't load up correctly or save correctly.

comment:12 Changed 8 years ago by Kim Neerings

Owner: changed from Testing to Kim Neerings
Status: newassigned

comment:13 Changed 8 years ago by Kim Neerings

Resolution: Fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.