Opened 8 years ago
Closed 7 years ago
#259 closed Defect (Fixed)
Saved Query issues epht-view & ibis/userSelections.html webpage not available
Reported by: | Paul Leo | Owned by: | matt and sasha |
---|---|---|---|
Priority: | *High | Milestone: | 2.3 - Testing |
Component: | View-App | Version: | 2.3 |
Severity: | Moderate Effort | Keywords: | saved query |
Cc: | tzheng@…, mmccord@…, kmarti@… |
Description (last modified by )
Working with Tong & Matt. A user account has been self registered. The account is eep@…. It was created to share saved queries. Folks at different workstations would log in with this user account to see saved queries.
Many saved queries appeared to have been saved, but when a user logs in - chrome displays this webpage is not available.
If the logged in user runs another query and saves it, the query list shows some queries, but not all. The saved query & selection list seem to work for other email accounts, both utah.gov & gmail accounts, both internally and externally from UT DOH. The same issue happens with this account on ibis.health.utah.gov & epht.health.utah.gov.
I've attached a few screen shots.
When someone saves a query with "illegal" characters, the save works, but when the user tries to bring up his/her saved queries he/she will get a blank page. One can save a new query, and a list of saved queries will come up, but it is only a partial list. The xlst transforms the xml until it hits an "illegal" character and then bales.
I've come to realize that as more and more of the general user population takes advantage of saved queries, and copies and pastes existing titles and descriptions into their own saved queries, this will become more of a support issue, as well as lead to unhappy users and adopters.
I can think of at least 3 ways of handling this:
- put a note on the saved query page instructing users to limit titles
and descriptions to letters and numbers and maybe a .
- remove special characters in the query's title and definition -- that
is; no longer use things like < or > and substitute either LT or GT, etc for the special characters, so that when a user cuts and pastes titles and definitions, there are no"illegal" characters available to create the issue
The above are only a stop gap. I think what needs to happen is...
- after 2.3 is released have community vote on priority or just have Garth create a filter that disallows the "illegal" character and puts up a popup and stops folks from saving their queries with "illegal" characters.
Attachments (4)
Change History (14)
Changed 8 years ago by
Attachment: | Image 20.png added |
---|
Changed 8 years ago by
Attachment: | Image 21.png added |
---|
different user logged in showing saved queries
Changed 8 years ago by
Attachment: | Image 22.png added |
---|
user eep@… logged into ibis.health.utah.gov showing webpage not found
Changed 8 years ago by
Attachment: | Image 23.png added |
---|
user eep@… logged int ibis but only showing subset of saved queries
comment:1 Changed 8 years ago by
Owner: | changed from garth.braithwaite@… to Garth Braithwaite |
---|
comment:2 Changed 8 years ago by
Milestone: | 2.2 - Testing |
---|---|
Owner: | Garth Braithwaite deleted |
Severity: | Unknown → Moderate Effort |
This is NOT a browser issue unless the browser is not able to handle HTML :)
Here's the file (40k in length - not an issue, well formed xml etc.): http://ibis.health.utah.gov/xml/query/definition/eep@utah.gov.xml
Here's the Error from the log: ibisph-view ERROR 11:43:06 o.i.xslt.Transformation - FATAL XSLT Error - Illegal HTML character: decimal 146
So, someone copied/pasted the extended quote (probably from MS-word) "’" and the xml parser blows up.
The solution is to scrub the data before putting into the XML.
comment:3 Changed 8 years ago by
Is this file http://ibis.health.utah.gov/xml/query/definition/eep@utah.gov.xml generated automatically? Nobody will be able to touch this file unless it's on our local host. ??? Tong
comment:4 Changed 8 years ago by
Well the file is generated and modified as a user adds, deletes, and modifies saved queries. What we think happened is that one of the names/titles/decriptions that a user entered when saving queries contained some "illegal" characters in this case a "’" and once it was saved the XML could no longer be read by application. Garth will need to add some more checking into that part of the code to remove "illegal" characters.
comment:5 Changed 8 years ago by
Description: | modified (diff) |
---|---|
Summary: | epht-view & ibis/userSelections.html webpage not available possibly just in chrome → Saved Query issues epht-view & ibis/userSelections.html webpage not available |
comment:6 Changed 8 years ago by
Description: | modified (diff) |
---|
edited because I did not like the way content was displayed
comment:7 Changed 8 years ago by
Milestone: | → 2.3 - Testing |
---|---|
Owner: | set to Testing |
SVN: 6908 Added pluggable/configurable string cleaning and validation code to the http request params to xml elements service. Tested putting the extended ascii char 146 into all three fields. Client name validator caught the invalid character in the saved query name. Java code stripped character before saving to XML.
Also, 2.3 java code had some issues with not replacing existing XML elements. This code was updated.
TESTING NOTE: pay attention to all XML generated by the application - published profiles, user account, saved queries and report any perceived issues.
comment:8 Changed 8 years ago by
Owner: | changed from Testing to matt and sasha |
---|---|
Version: | 2.2 → 2.3 |
comment:9 Changed 8 years ago by
Sasha in EPHT program said he used a walk about solution for 2.2. Will test in 2.3 to see if it's fixed.
comment:10 Changed 7 years ago by
Resolution: | → Fixed |
---|---|
Status: | new → closed |
User eep@… logged in showing webpage not found.