Opened 11 years ago
Closed 11 years ago
#163 closed Enhancement (Invalid)
Determine if PageSectionContent template in xslt\query\moduleresult\Page.xslt needs to be refactored, because needed to use core template to get mass view xml and output to excel buttons to appear
Reported by: | Paul Leo | Owned by: | |
---|---|---|---|
Priority: | Unknown | Milestone: | Unassigned |
Component: | View-App | Version: | Unknown |
Severity: | Minor Effort | Keywords: | query selection |
Cc: |
Description
In the 2.0 version of mass adopters ibisph-view there are two buttons in the query results page in div#results.Display.SubmitControl?. They are no longer there in the pre21 version of the mass adopters ibisph-view. It appears that part of the page no longer is included. See 3 page snippets - 2.0 output, 2.0 output using firefox inspect element 2.1 output
Attachments (3)
Change History (11)
Changed 11 years ago by
Attachment: | 2.0 query results output.png added |
---|
Changed 11 years ago by
Attachment: | 2.0 query results output showing element.png added |
---|
2.0 query results page showing element were button are
Changed 11 years ago by
Attachment: | pre21 query results with no button showing.png added |
---|
pre 2.1 query results page with no buttons
comment:1 Changed 11 years ago by
Changed http://www.ibisph.org/svn/main/adopters/ma/trunk/ibisph-view/src/main/webapp/xslt/html/query/module/result/SiteSpecific.xslt to include radio buttons for output to excel, and view xml. Tested and verified view xml works correctly in ff Need Garth's review to verify fix was made correctly according to standards of keeping adopters changes in SiteSpecific? files
Output to excel works, but displays warning that the file is in a different format than the .xls extension, and clicking yes to load the file results in warning that: there is a missing file css\stylesheet.css - Garth will also need to look at this
comment:2 Changed 11 years ago by
Summary: | pre 21 mass adopters Query Results no longer display output to excel and view xml buttons → Determine if PageSectionContent template in xslt\query\moduleresult\Page.xslt needs to be refactored, because pre 21 mass adopters Query Results no longer display output to excel and view xml buttons |
---|
Although the buttons now appear, in order to make them appear, I had to copy a core template into siteSpecific.xslt. I had to copy the Page.sectionsContent template from xslt\query\module\result\Page.xslt, in order to get the buttons where Mass had them originally using their code for the buttons. In discussing with Garth, there may be a need to refactor Page.xslt in order to have the adopters maintain less code. Of course there may also be an better way to implement the change, so Garth needs to review and determine a) whether there was a better way to do what I did and b) if there is not, look at a way to refactor Page.SectionsContent? in xslt\query\module\result\Page.xslt
comment:3 Changed 11 years ago by
Summary: | Determine if PageSectionContent template in xslt\query\moduleresult\Page.xslt needs to be refactored, because pre 21 mass adopters Query Results no longer display output to excel and view xml buttons → Determine if PageSectionContent template in xslt\query\moduleresult\Page.xslt needs to be refactored, because needed to use core template to get mass view xml and output to excel buttons to appear |
---|
comment:4 Changed 11 years ago by
Milestone: | 2.1 - Development → 2.1 - Testing |
---|---|
Owner: | changed from Garth Braithwaite to Paul Leo |
Priority: | High → Unknown |
Severity: | Major → Minor |
Type: | Defect → Enhancement |
If the items are to be located at the bottom of the page then Page.sectionsFooter template can be used.
NOTE: if you want to keep the current org unit info in that template then the template would include any nav type HTML link code followed by the current org unit code.
comment:5 Changed 11 years ago by
Owner: | changed from Paul Leo to Testing |
---|
Submission was moved to a separate template.
comment:6 Changed 11 years ago by
Milestone: | 2.1 - Testing → Unassigned |
---|---|
Owner: | Testing deleted |
Version: | 2.1 → Unknown |
comment:7 Changed 11 years ago by
Keywords: | query selection added |
---|
comment:8 Changed 11 years ago by
Resolution: | → Invalid |
---|---|
Status: | new → closed |
Discussed in CoP call, leaving to adopter how to implement various options.
2.0 ma adopters query results page showing view and output buttons