Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#112 closed Enhancement (Fixed)

The ' ; ' seperator between indicator graph and query results data sources

Reported by: Lois Haggard Owned by: Lois Haggard
Priority: -Low Milestone:
Component: View-App Version: 2.0
Severity: Keywords:
Cc:

Description (last modified by Lois Haggard)

When there is more than one data source for a given indicator graph, each data source entry is followed by a semi-colon (;).

The problem is that the semi-colon appears after every data source (even the last one listed), and it appears in addition to whatever punctuation is already there.

The code is in the xslt/html/indicator/profile/Indicator.xslt file on line 388, as follows:

<xsl:if test="(count($indicatorDataSources/DATA_SOURCE) &gt; 0) or (count($indicatorViewDataSources/DATA_SOURCE) &gt; 0)">
	<h2 title="Metadata about this indiactor profiles data sources">Data Sources</h2>
	<xsl:for-each-group 
		select="$indicatorDataSources/DATA_SOURCE union $indicatorViewDataSources/DATA_SOURCE" 
		group-by="NAME"
	>
		<xsl:sort select="SORT_ORDER"/>
		<xsl:value-of select="TEXT"/>; 
	</xsl:for-each-group>
	<br/><br/>
</xsl:if>

IMHO, a better option would be to leave the semi-colon off, and to punctuate and identify the data sources in the xml data source data.

For instance,

New Mexico Data Source, 2006 and later: New Mexico Electronic
Disease Surveillance System (NM-EDSS), Infectious Disease 
Epidemiology Bureau, New Mexico Department of Health.  U.S. Data
Source: National Notifiable Diseases Surveillance System (NNDSS), 
Centers for Disease Control and Prevention.

Similar thinking may be applied to the Data Sources section on the IBIS-Q results page. This can be found in the xslt/html/query/module/results/ResultPage.xslt file on line 297:

<xsl:if test="count($Result.configuration/DATA_SOURCES/DATA_SOURCE) &gt; 0">
	<h2>Data Sources</h2>
	<xsl:for-each select="$Result.configuration/DATA_SOURCES/DATA_SOURCE">
		<xsl:sort select="SORT_ODRER" order="ascending" data-type="number"/>
		<xsl:if test="position() &gt; 1">;&#160;</xsl:if>
		<xsl:value-of select="TEXT"/>
	</xsl:for-each>
	<br/><br/>
</xsl:if>

If we punctuate and identify our data sources in the xml, we'll have tidier pages with no strange semi-colons hanging around.

Death data: New Mexico Death Certificate Database, Office of Vital 
Records and Statistics, New Mexico Department of Health.  Source 
for 2000 and later Population Estimates: University of New Mexico, 
Bureau of Business and Economic Research, 
http://www.unm.edu/~bber/. Source for 1990 - 1999 Population 
Estimates: Centers for Disease Prevention and Control, National 
Center for Health Statistics, 
http://www.cdc.gov/nchs/about/major/dvs/popbridge/datadoc.htm. 


5/3/2011 - This is in the latest View app code.

Change History (6)

comment:1 Changed 9 years ago by Lois Haggard

Description: modified (diff)

comment:2 Changed 9 years ago by Lois Haggard

Owner: changed from utah to Lois Haggard

comment:3 Changed 9 years ago by Lois Haggard

Description: modified (diff)

comment:4 Changed 9 years ago by Lois Haggard

Summary: The ' ; ' seperator between indicator data sourcesThe ' ; ' seperator between indicator graph and query results data sources

comment:5 Changed 8 years ago by Lois Haggard

Description: modified (diff)
Resolution: fixed
Status: newclosed

comment:6 Changed 8 years ago by (none)

Milestone Parking Lot deleted

Note: See TracTickets for help on using tickets.